Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CodingSpectator support Eclipse Indigo SR1 #338

Closed
reprogrammer opened this issue Dec 21, 2011 · 6 comments
Closed

Make CodingSpectator support Eclipse Indigo SR1 #338

reprogrammer opened this issue Dec 21, 2011 · 6 comments
Labels
Installation Release
Milestone
December 26, 2011

Comments

@reprogrammer
Copy link
Collaborator

We need to create another set of patches to support CodingSpectator on Eclipse Indigo SR1 (3.7.1). This issue relates to issues #327, #328, and #330.
reprogrammer added a commit that referenced this issue Dec 21, 2011
@reprogrammer
Initial commit of org.eclipse.ltk.core.refactoring.
57249f8 
3.5.201.r371_v20110824-0800

This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 21, 2011
@reprogrammer
Patched org.eclipse.ltk.core.refactoring.
bf4ef7e 
This commit belongs to issue #338.
@reprogrammer
Copy link
Collaborator Author

@Wanderer777

I followed the instructions at https://github.com/vazexqi/CodingSpectator/wiki/Supporting-Indigo-SR1 to patch "org.eclipse.ltk.core.refactoring" in bf4ef7e.

reprogrammer added a commit that referenced this issue Dec 21, 2011
@reprogrammer
Initial commit of org.eclipse.ltk.ui.refactoring 3.6.0.qualifier.
b0e2d3d 
3.6.0.v20110505-0800

This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 21, 2011
@reprogrammer
Patched org.eclipse.ltk.ui.refactoring.
622b045 
This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 21, 2011
@reprogrammer
Initial commit of org.eclipse.jdt.core 3.7.1.qualifier.
ca570eb 
3.7.1.v_B76_R37x

This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 21, 2011
@reprogrammer
Patched org.eclipse.jdt.core.
e881fe5 
This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 21, 2011
@reprogrammer
Initial commit of org.eclipse.jdt.ui 3.7.1.qualifier.
c628d84 
3.7.1.r371_v20110824-0800

This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 21, 2011
@reprogrammer
Patched org.eclipse.jdt.ui.
5fc6e5d 
The patch generated from the Indigo version of the org.eclipse.jdt.ui plug-in didn't work on the following files because of whitespaces:

- ui/org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessor.java
- core refactoring/org/eclipse/jdt/internal/corext/refactoring/code/ExtractMethodRefactoring.java
- core refactoring/org/eclipse/jdt/internal/corext/refactoring/code/ExtractTempRefactoring.java
- core refactoring/org/eclipse/jdt/internal/corext/refactoring/code/InlineConstantRefactoring.java
- core refactoring/org/eclipse/jdt/internal/corext/refactoring/code/InlineTempRefactoring.java

It was easy to fix the patch for the above files.

This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 21, 2011
@reprogrammer
Initial commit of org.eclipse.jdt.core.manipulation 1.4.0.qualifier.
d141a32 
1.4.0.v20110505-0800

This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 21, 2011
@reprogrammer
Patched org.eclipse.jdt.core.manipulation.
125e98f 
This commit belongs to issue #338.
@reprogrammer
Copy link
Collaborator Author

@Wanderer777:

I patched LTK and JDT plug-ins in 57249f8 .. 125e98f. My next step is to test these patches.

@reprogrammer reprogrammer mentioned this issue Dec 22, 2011
Closed
@reprogrammer
Copy link
Collaborator Author

@Wanderer777:

The plug-in org.eclipse.jdt.core has been modified for CodingTracker only, but, I patched in anyways. However, the patch produced the following compilation problem. Would you fix this compilation problem in org.eclipse.jdt.core?

Description Resource    Path    Location    Type
resourceListener cannot be resolved or is not a field   Buffer.java /org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core   line 401    Java Problem

reprogrammer added a commit that referenced this issue Dec 22, 2011
@reprogrammer
Added a symlink for the errorlog plug-in of Indigo SR1.
e40caa2 
The "edu.illinois.codingspectator.errorlog" plug-in for Indigo works fine for Indigo SR1. So, I just added a symlink from "indigo-sr1/edu.illinois.codingspectator.errorlog" to "indigo/edu.illinois.codingspectator.errorlog".

This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 22, 2011
@reprogrammer
Added symlinks for UDC plug-ins of Indigo SR1.
6a914d9 
The UDC plug-ins haven't changed since Indigo. So, I added the corresponding symlinks from indigo-sr1 to indigo.

This commit belongs to issue #338.
Wanderer777 added a commit that referenced this issue Dec 22, 2011
@Wanderer777
Initial commit of org.eclipse.ui.workbench.texteditor.
c2f8fad 
3.7.0.v20110505-0800

This commit belongs to issue #338.
Wanderer777 added a commit that referenced this issue Dec 22, 2011
@Wanderer777
Patched org.eclipse.ui.workbench.texteditor.
b758dfc 
This commit belongs to issue #338.
Wanderer777 added a commit that referenced this issue Dec 22, 2011
@Wanderer777
Initial commit of org.eclipse.ui.editors.
9b08f4b 
3.7.0.v20110517-0800

This commit belongs to issue #338.
Wanderer777 added a commit that referenced this issue Dec 22, 2011
@Wanderer777
Patched org.eclipse.ui.editors.
c62989f 
This commit belongs to issue #338.
Wanderer777 added a commit that referenced this issue Dec 22, 2011
@Wanderer777
Initial commit of org.eclipse.compare.
8367961 
3.5.201.R37x_v20110817-0800

This commit belongs to issue #338.
Wanderer777 added a commit that referenced this issue Dec 22, 2011
@Wanderer777
Patched org.eclipse.compare.
c5a95a5 
This commit belongs to issue #338.
Wanderer777 added a commit that referenced this issue Dec 22, 2011
@Wanderer777
Initial commit of org.eclipse.core.resources.
50d07d7 
3.7.100.v20110510-0712

This commit belongs to issue #338.
Wanderer777 added a commit that referenced this issue Dec 22, 2011
@Wanderer777
Patched org.eclipse.core.resources.
d8ae385 
This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 23, 2011
@reprogrammer
Deleted the CVS meta data of UDC plug-ins modified for Indigo.
5b3fa00 
I made this change while working on issue #338.
@reprogrammer
Copy link
Collaborator Author

When I try to build the update site, I get the following error message:

eclipse.buildId=M20110909-1335
java.version=1.7.0_147-icedtea
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Framework arguments:  -product org.eclipse.epp.package.rcp.product
Command-line arguments:  -os linux -ws gtk -arch x86_64 -product org.eclipse.epp.package.rcp.product

Error
Thu Dec 22 20:47:25 CST 2011
Unable to find feature "org.eclipse.platform" with version in range [3.7.0,3.7.1).

Note that I'm building the update site from within Eclipse Indigo SR1 and the version of org.eclipse.platform that comes with Eclipse Indigo SR1 is 3.7.1.v201109091335.

Setting the imported version of org.eclipse.platform in edu.illinois.codingspectator.platform.patch/feature.xml to that of the one installed in Eclipse Indigo SR1 didn't fix the problem:

<requires>
  <import feature="org.eclipse.platform" version="3.7.1.r37x_v20110729-9gF7UHOxFtniV7mI3T556iZN9AU8bEZ1lHMcVK" patch="true"/>
</requires>

When I closed the org.eclipse.epp.usagedata.* bundles, the above error message disappeared. Perhaps it was wrong to assume that the copy of UDC bundles for Indigo were safe to use for Indigo SR1. I will investigate.

It seems that the problem is the license-feature-version attribute in org.eclipse.epp.usagedata.feature/feature.xml. The value of this attribute should be 3.7.1.qualifier not 3.7.0.qualifier in Eclipse Indigo SR1. Surprisingly, this attribute is 3.7.0.qualifier in the HEAD of the CVS repository as of Dec. 23, 2011. The version number of the UDC feature installed on Eclipse Indigo SR1 is org.eclipse.epp.usagedata.feature_1.4.0.R201106061540. This confirms that the UDC bundles haven't in Eclipse Indigo and Indigo SR1 are the same. However, the license-feature-version attribute in this version of this feature doesn't look right, at least for our purposes. So, I'm going to patch the feature for Eclipse Indigo SR1.

@reprogrammer
Copy link
Collaborator Author

When I tried to install CodingSpectator on Eclipse Indigo SR1, I got the following error message:

Cannot complete the install because one or more required items could not be found.
  Software being installed: CodingSpectator 1.0.0.201112230012 (edu.illinois.codingspectator.feature.group 1.0.0.201112230012)
  Missing requirement: edu.illinois.codingtracker.operations 1.0.0.201112230012 (edu.illinois.codingtracker.operations 1.0.0.201112230012) requires 'bundle edu.illinois.codingtracker.compare.helpers 0.0.0' but it could not be found
  Cannot satisfy dependency:
    From: CodingSpectator 1.0.0.201112230012 (edu.illinois.codingspectator.feature.group 1.0.0.201112230012)
    To: edu.illinois.codingtracker.feature.feature.group [1.0.0.201112230012]
  Cannot satisfy dependency:
    From: CodingTracker Feature 1.0.0.201112230012 (edu.illinois.codingtracker.feature.feature.group 1.0.0.201112230012)
    To: edu.illinois.codingtracker.operations [1.0.0.201112230012]

The plug-in edu.illinois.codingtracker.compare.helpers has to be included in the CodingTracker feature.

reprogrammer added a commit that referenced this issue Dec 23, 2011
@reprogrammer
Updated the update site post processing scripts for Eclipse Indigo SR1.
db5b13f 
This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 23, 2011
@reprogrammer
Initial commit of org.eclipse.epp.usagedata.feature.
c1359a9 
:pserver:anonymous@dev.eclipse.org:/cvsroot/technology
Versions/org.eclipse.epp/org.eclipse.epp INDIGO_R

This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 23, 2011
@reprogrammer
Updated "license-feature-version" in UDC.
9d19749 
Updated the "license-feature-version" attribute in `plug-ins/indigo-sr1/org.eclipse.epp.usagedata.feature/feature.xml` to "3.7.1.qualifier" to be able to bulid the update site from within Eclipse Indigo SR1.

This commit belongs to issue #338.
reprogrammer added a commit that referenced this issue Dec 23, 2011
@reprogrammer
Added *.compare.helpers to *.codingtracker.feature.
3b5ed4a 
This commit belongs to issue #338.
@reprogrammer
Copy link
Collaborator Author

Eclipse Indigo SR1 refused to install CodingSpectator because it couldn't verify the signed JARs. Eclipse generated the following exception in its error log during the installation of CodingSpectator:

java.security.SignatureException: An error occurred while processing the signatures for the file: /tmp/signatureFile6183059849499261382.jar
    at org.eclipse.osgi.internal.signedcontent.SignedBundleHook.getSignedContent(SignedBundleHook.java:260)
    at org.eclipse.equinox.internal.p2.artifact.repository.SignatureVerifier.verifyContent(SignatureVerifier.java:77)
    at org.eclipse.equinox.internal.p2.artifact.repository.SignatureVerifier.verify(SignatureVerifier.java:59)
    at org.eclipse.equinox.internal.p2.artifact.repository.SignatureVerifier.close(SignatureVerifier.java:100)
    at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.reportStatus(SimpleArtifactRepository.java:1132)
    at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.downloadArtifact(SimpleArtifactRepository.java:570)
    at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.getArtifact(SimpleArtifactRepository.java:680)
    at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.getArtifact(MirrorRequest.java:260)
    at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.transferSingle(MirrorRequest.java:235)
    at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.transfer(MirrorRequest.java:191)
    at org.eclipse.equinox.internal.p2.artifact.repository.MirrorRequest.perform(MirrorRequest.java:122)
    at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.getArtifact(SimpleArtifactRepository.java:664)
    at org.eclipse.equinox.internal.p2.artifact.repository.simple.SimpleArtifactRepository.getArtifacts(SimpleArtifactRepository.java:735)
    at org.eclipse.equinox.internal.p2.engine.DownloadManager.fetch(DownloadManager.java:110)
    at org.eclipse.equinox.internal.p2.engine.DownloadManager.start(DownloadManager.java:99)
    at org.eclipse.equinox.internal.p2.engine.phases.Collect.completePhase(Collect.java:76)
    at org.eclipse.equinox.internal.p2.engine.Phase.postPerform(Phase.java:216)
    at org.eclipse.equinox.internal.p2.engine.Phase.perform(Phase.java:84)
    at org.eclipse.equinox.internal.p2.engine.PhaseSet.perform(PhaseSet.java:44)
    at org.eclipse.equinox.internal.p2.engine.Engine.perform(Engine.java:75)
    at org.eclipse.equinox.internal.p2.engine.Engine.perform(Engine.java:44)
    at org.eclipse.equinox.p2.operations.ProvisioningSession.performProvisioningPlan(ProvisioningSession.java:174)
    at org.eclipse.equinox.p2.operations.ProfileModificationJob.runModal(ProfileModificationJob.java:79)
    at org.eclipse.equinox.p2.operations.ProvisioningJob.run(ProvisioningJob.java:177)
    at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: java.security.SignatureException: Either the manifest file or the signature file has been tampered in this jar: /tmp/signatureFile6183059849499261382.jar
    at org.eclipse.osgi.internal.signedcontent.SignatureBlockProcessor.verifyManifestAndSignatureFile(SignatureBlockProcessor.java:154)
    at org.eclipse.osgi.internal.signedcontent.SignatureBlockProcessor.processSigner(SignatureBlockProcessor.java:104)
    at org.eclipse.osgi.internal.signedcontent.SignatureBlockProcessor.process(SignatureBlockProcessor.java:59)
    at org.eclipse.osgi.internal.signedcontent.SignedBundleFile.setBundleFile(SignedBundleFile.java:47)
    at org.eclipse.osgi.internal.signedcontent.SignedBundleHook.getSignedContent(SignedBundleHook.java:256)
    ... 24 more

The jarsigner program reports our JARs as invalid, too:

jarsigner -verify org.eclipse.jdt.ui_3.7.1.201112231000.jar 
jar verified.

Warning: 
This jar contains entries whose certificate chain is not validated.

Re-run with the -verbose and -certs options for more details.

The command jarsigner -verify -verbose -certs edu.illinois.codingspectator.data_1.0.0.201112231000.jar reported the following:

s        657 Fri Dec 23 10:03:12 CST 2011 META-INF/MANIFEST.MF

      X.509, CN=CodingSpectator Team, OU=Department of Computer Science, O=University of Illinois, L=Urbana, ST=Illinois, C=US
      [certificate is valid from 12/23/11 12:21 AM to 1/26/13 12:21 AM]
      [CertPath not validated: null]

         379 Fri Dec 23 10:03:12 CST 2011 META-INF/CODINGSP.SF
        1186 Fri Dec 23 10:03:12 CST 2011 META-INF/CODINGSP.DSA
           0 Fri Dec 23 10:01:36 CST 2011 META-INF/
           0 Fri Dec 23 10:01:06 CST 2011 edu/
           0 Fri Dec 23 10:01:06 CST 2011 edu/illinois/
           0 Fri Dec 23 10:01:06 CST 2011 edu/illinois/codingspectator/
           0 Fri Dec 23 10:01:06 CST 2011 edu/illinois/codingspectator/data/
sm      1725 Fri Dec 23 10:01:06 CST 2011 edu/illinois/codingspectator/data/CodingSpectatorDataPlugin.class

      X.509, CN=CodingSpectator Team, OU=Department of Computer Science, O=University of Illinois, L=Urbana, ST=Illinois, C=US
      [certificate is valid from 12/23/11 12:21 AM to 1/26/13 12:21 AM]
      [CertPath not validated: null]


  s = signature was verified 
  m = entry is listed in manifest
  k = at least one certificate was found in keystore
  i = at least one certificate was found in identity scope

jar verified.

Warning: 
This jar contains entries whose certificate chain is not validated.

I need to sign the JARs with Sun/Oracle JDK not OpenJDK (See http://stackoverflow.com/a/4344836/130224). I successfully signed the JARs using Sun JDK 6 but not Oracle JDK 7.

@reprogrammer reprogrammer mentioned this issue Dec 23, 2011
Closed
reprogrammer added a commit that referenced this issue Dec 25, 2011
@reprogrammer
Added Indigo SR1 to the user guide.
0704bbf 
Added the update site of CodingSpectator for Eclipse Indigo SR1 to the user guide.

This commit belongs to issue #338.
This was referenced Dec 27, 2011
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Installation Release
Projects
None yet
Milestone
December 26, 2011
Development

No branches or pull requests
1 participant
@reprogrammer