Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upstream changes from DRF-3.10 #58

Closed
wants to merge 2 commits into from

Conversation

tfranzel
Copy link

@tfranzel tfranzel commented Jul 13, 2019

DRF has dropped python 2 support with version 3.10 and Django has dropped it in master. If this lib wants to keep compatibility it needs to pull out six support into requirements.txt as it cannot import six from new rest_framework versions.

PR #59 had the right idea, but from django.util import six will also not be available anymore

@erseco
Copy link

erseco commented Jul 18, 2019

Waiting to this PR to be merged, meanwhile, I added this to my Dockerfile to monkey-patch the library:

# Temporary fix for https://github.com/vbabiy/djangorestframework-camel-case/issues/61
RUN sed -i "s/import six, FormParser/import FormParser/" /usr/lib/python3.6/site-packages/djangorestframework_camel_case/parser.py

@speedy250
Copy link

Would love to get this merged and pushed live!!

@canassa canassa mentioned this pull request Jul 25, 2019
@vbabiy vbabiy closed this in #65 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants