Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude pattern for git checks #21

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Conversation

dmcgowan
Copy link
Contributor

Allows excluding of vendor directories for whitespace checks

see failure for containerd/containerd#771

$ TRAVIS_COMMIT_RANGE="${TRAVIS_COMMIT_RANGE/.../..}" make dco
git-validation -q -run DCO,short-subject,dangling-whitespace
 fcef902 - FAIL - has whitespace errors. See `git show --check fcef902aa5583e3efde5456562fd84e09c835258`.
1 commits to fix
make: *** [dco] Error 1

The problem was in a vendored README

vendor/github.com/godbus/dbus/README.markdown:28: trailing whitespace.
+gives a short overview over the basic usage. 

This allows setting GIT_CHECK_EXCLUDE="./vendor" for go projects to exclude the check here

Allows excluding of vendor directories for whitespace checks

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
@vbatts
Copy link
Owner

vbatts commented Apr 27, 2017

tough problem. thanks for this. I'll add docs in a separate pr
LGTM

@vbatts vbatts merged commit e6a550d into vbatts:master Apr 27, 2017
vbatts added a commit that referenced this pull request Apr 27, 2017
#21

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
vbatts added a commit that referenced this pull request Apr 27, 2017
#21

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
vbatts added a commit that referenced this pull request Apr 27, 2017
#21

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants