Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make .cli.test doesn't error out #98

Closed
cyphar opened this issue Nov 19, 2016 · 1 comment
Closed

make .cli.test doesn't error out #98

cyphar opened this issue Nov 19, 2016 · 1 comment

Comments

@cyphar
Copy link
Contributor

cyphar commented Nov 19, 2016

Because of how the .cli.test rule is written, make will not exit with an error. I noticed this while adding tests to #96. It's a little concerning to be honest.

Also, I don't understand why you've implemented the touch .cli.test code. Why should testing ever be skipped?
vbatts added a commit that referenced this issue Nov 22, 2016
@vbatts
cli.test: fail on cli tests
f49f66f 
This cleans up the Makefile target, and drops the dependency to point to
the $root path of the repo.

Fixes #98

Reported-by: Aleksa Sarai <asarai@suse.de>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@vbatts vbatts mentioned this issue Nov 22, 2016
Merged
@vbatts
Copy link
Owner

vbatts commented Nov 22, 2016

fixed in #99

And I've added the touch $@ because it depends on the build, and the build depends on the source files. If it ran successfully and nothing has changed then no need to retest. If anything has changed, then it all gets done again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbatts @cyphar