Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(component): 修复 useComponentRegister 方法无法添加自定义的组件,添加时爆类型错误的问题 #3483

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

cMing1997
Copy link

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wangjue666
Copy link
Collaborator

提供下复现代码

@cMing1997
Copy link
Author

提供下复现代码

import {  useComponentRegister} from '@/components/Form';

import SelectRoles from './SelectRoles.vue';

useComponentRegister('SelectRoles', SelectRoles);

这里的 SelectRoles 可以是任何的自定义组件

@wangjue666
Copy link
Collaborator

的确,这个函数的设计有问题, useComponentRegister 方法要设定的组件名称不应该 只限定ComponentType类型

@wangjue666 wangjue666 merged commit 98e2e4c into vbenjs:main Jan 2, 2024
2 checks passed
@vbenjs vbenjs locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants