Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ScrollContainer): enable x scroll #3564

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

xachary
Copy link

@xachary xachary commented Jan 22, 2024

General

根据 #3563 确实存在提到的问题2,看提交记录一直存在以下样式锁死:
src\components\Container\src\ScrollContainer.vue

  .scroll-container {
    width: 100%;
    height: 100%;

    .scrollbar__wrap {
      margin-bottom: 18px !important;
      overflow-x: hidden; // 这里锁死了横向滚动的可能性
    }

    .scrollbar__view {
      box-sizing: border-box;
    }
  }

请问管理员,这里最初的用意是?注释掉,做 demo 里没发现问题。

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • [x I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@likui628 likui628 merged commit a1e862b into vbenjs:main Jan 23, 2024
2 checks passed
@vbenjs vbenjs locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants