Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(BasicTree): 组件外部获取treeData不必通过treeDataRef.value或许更好些 #3353

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

zwtvip
Copy link
Contributor

@zwtvip zwtvip commented Nov 27, 2023

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wangjue666
Copy link
Collaborator

这样改后,传递值的时候就得传递 响应式对象,使用这个组件就会麻烦点

@zwtvip
Copy link
Contributor Author

zwtvip commented Nov 28, 2023

这样改后,传递值的时候就得传递 响应式对象,使用这个组件就会麻烦点

这样改还是可以正常拿到增删改查后的数据,内部本来就监听了,函数永远返回的最新值,不知道我这样理解对不

@wangjue666
Copy link
Collaborator

@zwtvip 抱歉是我看岔眼了, 我当时想的是gettreedata返回treeData的响应式数据,组件外面可以对他进行一些操作

@wangjue666 wangjue666 merged commit 943f500 into vbenjs:main Dec 4, 2023
2 checks passed
zyt520ham pushed a commit to zyt520ham/vue-vben-admin that referenced this pull request Dec 14, 2023
* main: (224 commits)
  fix:修复气泡确认框的底部按钮换行的问题 (vbenjs#3413)
  style: tabs bottom double line fix (vbenjs#3415)
  feat(IconPicker): IconPicker could allowClear and readonly for form (vbenjs#3414)
  fix(FormTable): Invert select bug (vbenjs#3412)
  chore: 自定义组件默认rule校验默认触发逻辑为blur
  chore(ApiRadioGroup): 移除多余的change事件
  fix(ApiSelect): 修复监听不到params的变动
  fix(BasicForm->ApiRadioGroup): when options click, duplicate requests. resolve vbenjs#3387
  Revert "feat: table搜索表单值发生改变可以触发reload (vbenjs#3378)" (vbenjs#3407)
  fix(BasicTable): ColumnSetting mistake when use setColumns (vbenjs#3408)
  fix: navigator.clipboard 兼容问题 vbenjs#3372 (vbenjs#3403)
  feat: ColumnSetting and SizeSetting persist (vbenjs#3398)
  fix(BasicDrawer): remove toRaw props (vbenjs#3399)
  feat(hooks): useWatermark添加水印防篡改功能(vbenjs#3395) (vbenjs#3397)
  fix: table height calc when fullcontent and footer visible change (vbenjs#3392)
  fix(BasicTable): table表格宽度自适应,隐藏的列导致宽度增加 (vbenjs#3388)
  fix: 使用suffix时,label没有垂直居中 (vbenjs#3384)
  feat: table搜索表单值发生改变可以触发reload (vbenjs#3378)
  feat(treeTable): add function collapseRows and demo (vbenjs#3375)
  perf(BasicTree): 外部获取treeData不必通过treeDataRef.value (vbenjs#3353)
  ...

# Conflicts:
#	internal/eslint-config/.eslintignore
#	internal/stylelint-config/.eslintignore
#	internal/vite-config/.eslintignore
#	package.json
#	pnpm-lock.yaml
#	src/locales/lang/en/sys.ts
#	src/locales/lang/zh-CN/sys.ts
#	src/store/modules/user.ts
#	src/views/demo/feat/session-timeout/index.vue
@zwtvip zwtvip deleted the tree branch January 9, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants