New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dimesion settings to metric #5

Open

asatriani wants to merge 1 commit into vbessler:master from asatriani:master

asatriani commented May 6, 2017 •

edited

Loading

Add custom dimension to metric div to cover a specific area on picture relative to metric. Center metric text horizontally and vertically.


          Add dimesion settings to metric

28e9c6e

Owner

vbessler commented Jun 11, 2017

Hi asatriani,
Thanks for the pull request. I had some issues with your change.

When I enter in dimension widths/height I can't get the metric back to a state where it autosizes.

Also I get the following error (am using chrome):

TypeError: Cannot read property 'toString' of undefined
at render (http://localhost:3000/public/plugins/bessler-pictureit-panel/pictureit_ctrl.js?bust=1497216112779:150:57)
at eval (http://localhost:3000/public/plugins/bessler-pictureit-panel/pictureit_ctrl.js?bust=1497216112779:165:8)
at e.emit (http://localhost:3000/public/app/boot.js:48:17959)
at a.emit (http://localhost:3000/public/app/boot.js:48:19617)
at PictureItCtrl.a.render (http://localhost:3000/public/app/boot.js:42:9821)
at PictureItCtrl.onDataReceived (http://localhost:3000/public/plugins/bessler-pictureit-panel/pictureit_ctrl.js?bust=1497216112779:99:12)
at e.emit (http://localhost:3000/public/app/boot.js:48:17526)
at a.emit (http://localhost:3000/public/app/boot.js:48:19617)
at PictureItCtrl.f.handleQueryResult (http://localhost:3000/public/app/boot.js:42:19805)
at g (http://localhost:3000/public/app/boot.js:38:29545)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment