Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/split #194

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Feature/split #194

merged 4 commits into from
Oct 9, 2023

Conversation

vbuch
Copy link
Owner

@vbuch vbuch commented Oct 4, 2023

Will merge it remotely once done. Creating this to track progress.

@coveralls
Copy link

coveralls commented Oct 4, 2023

Coverage Status

coverage: 99.515% (-0.5%) from 100.0% when pulling caf4114 on feature/split into 2d3e49d on develop.

@vbuch vbuch force-pushed the feature/split branch 3 times, most recently from 39a495a to 10d3187 Compare October 4, 2023 13:22
@vbuch vbuch temporarily deployed to github-pages October 4, 2023 16:11 — with GitHub Pages Inactive
@vbuch vbuch temporarily deployed to github-pages October 5, 2023 08:36 — with GitHub Pages Inactive
@vbuch vbuch temporarily deployed to github-pages October 5, 2023 09:21 — with GitHub Pages Inactive
@vbuch vbuch temporarily deployed to github-pages October 5, 2023 09:25 — with GitHub Pages Inactive
@vbuch vbuch temporarily deployed to github-pages October 5, 2023 09:26 — with GitHub Pages Inactive
@vbuch
Copy link
Owner Author

vbuch commented Oct 5, 2023

@hscstudio @JMHAVANCE @fdimarh @AkshayThakurcr @20manas I would love to hear your thoughts on the examples that are coming with the new version: https://github.com/vbuch/node-signpdf/tree/feature/split/packages/examples/src as you were asking for these in #159

@vbuch vbuch marked this pull request as draft October 5, 2023 10:04
@vbuch vbuch force-pushed the feature/split branch 3 times, most recently from 677ea69 to 5b70ce6 Compare October 5, 2023 12:31
@vbuch vbuch mentioned this pull request Oct 6, 2023
2 tasks
@vbuch vbuch marked this pull request as ready for review October 6, 2023 09:50
@vbuch vbuch force-pushed the feature/split branch 2 times, most recently from dc8fd50 to 9927f17 Compare October 6, 2023 10:22
… packages

* Split the helpers into separate packages `@signpdf/placeholder-pdfkit010` and `@signpdf/placeholder-plain`;
* placeholder helpers now require `contactInfo`, `location` and `name` which used to be optional;
* Introduced more types declarations through TS and JSDoc;
* Introduced examples in `packages/examples`;
Introducing @signpdf/signer-p12 and making signpdf's sign() method async

Co-authored-by: Daniel Hensby <git@hens.by>
@vbuch vbuch merged commit 13182e0 into develop Oct 9, 2023
1 check passed
@vbuch vbuch deleted the feature/split branch October 9, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants