Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF Error #217

Merged
merged 2 commits into from
Jan 19, 2024
Merged

EOF Error #217

merged 2 commits into from
Jan 19, 2024

Conversation

AviramBaranes
Copy link
Contributor

No description provided.

Files that ends with '\r%%EOF' will no longer throw an error
Update removeTrailingNewLine.js
@dhensby
Copy link
Collaborator

dhensby commented Dec 19, 2023

Is a carriage return in a PDF file actually allowed within the PDF specification?

@vbuch
Copy link
Owner

vbuch commented Dec 19, 2023

Yes @dhensby

Quoting the specs:

The carriage return (CR) and line feed (LF) characters, also called newline characters, are treated as end-of-line (EOL) markers. The combination of a carriage return followed immediately by a line feed is treated as one EOL marker.

@vbuch
Copy link
Owner

vbuch commented Jan 2, 2024

Because this is not even built, I cannot just merge it. Will try to do the merge and build and look around for other places where this is broken. Hopefully soon.

@vbuch vbuch merged commit 6804b63 into vbuch:develop Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants