Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placeholder-pdf-lib's .d.ts #238

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Fix placeholder-pdf-lib's .d.ts #238

merged 3 commits into from
Mar 18, 2024

Conversation

vbuch
Copy link
Owner

@vbuch vbuch commented Mar 15, 2024

Fix the reported missing import of pdf-lib's PDFPage that we use as a parameter type.
To automate the process I additionally introduce tsd as a tool to validate the types we generate. Only doing an import with no additional type tests.

Fixes #234

@coveralls
Copy link

Coverage Status

coverage: 99.636%. remained the same
when pulling 7749d8d on bugfix/234-pdf-lib-dts
into 13b071e on develop.

@vbuch vbuch merged commit 1c79a47 into develop Mar 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails because of missing type
4 participants