-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare a new major version #24
Conversation
It is not a fully completed feature. There is much more to implement.
Bundle pdfkit code with its license. Ignore it when generating test coverage.
57c2118
to
3dabcf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signatures of pdfkitAddPlaceholder and plainAddPlaceholder differ. They may at least both use Paramater Objects. plainAddPlaceholder accepts its buffer separately.
@maldimirov if/when you have time, could you give the code a glance? If/when you have more time, you could even modify what you don't like :) I'm not asking @samaleksov because he has some other coding snippets to do... |
@vbuch could we list what's missing in PDF signature verification to start working on, instead of removing this functionality from the library? |
@MohammedEssehemy there were more than one reasons when i descided that.
As I already wrote, the best would be if you created a separate package for that. I would be more than happy to help extract some helpers out into a shared lib so you dont have to rewrite or copy/paste them. Also I would be happy to use it in the testing of this repo. I also think it can be used in the tests of node-forge once available to verify the detached signing. |
@vbuch I'll work with my team on separating the package and will inform you once the package is ready, and will tell you about the helpers we need. |
@vbuch we have released version 0.1.0 from the library with multiple bug fixes. |
I'm doing more than one thing at a time. While this is WIP, I'm logging changes in the CHANGELOG. The main feature is the helper to sign a non-pdfkit created document as per #22