Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plainAddPlaceholder for when /Annots are already in the document #57

Merged
merged 5 commits into from Jan 30, 2020
Merged

Fix plainAddPlaceholder for when /Annots are already in the document #57

merged 5 commits into from Jan 30, 2020

Conversation

vbuch
Copy link
Owner

@vbuch vbuch commented Jan 30, 2020 •
edited

Addresses #56. Not yet mergable. createBufferPageWithAnnotation needs to be tested.

May also fix #55 #50 #48. May also be the last issue in #39

@coveralls
Copy link

Pull Request Test Coverage Report for Build 256

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 250: 0.0%
Covered Lines: 276
Relevant Lines: 276
💛 - Coveralls

This was referenced Jan 30, 2020
Closed
Closed
Closed
@vbuch vbuch added the bug label Jan 30, 2020
@vbuch vbuch changed the title [WIP] Fix plainAddPlaceholder for when /Annots are already in the document Fix plainAddPlaceholder for when /Annots are already in the document Jan 30, 2020
@vbuch vbuch merged commit c71f4c5 into develop Jan 30, 2020
@vbuch vbuch deleted the fix-plain-helper-for-link branch January 30, 2020 21:55
This was referenced Jan 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First page of PDF is blank after signature
2 participants
@vbuch @coveralls