Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch example crashes on touch devices #224

Closed
JesperJuul opened this issue Dec 14, 2023 · 3 comments
Closed

Touch example crashes on touch devices #224

JesperJuul opened this issue Dec 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@JesperJuul
Copy link

It looks like recent versions have a bug in the touch code?

If I run https://vc64web.github.io/doc/wiki/player_example2.html either on my phone (Firefox or Chrome) or in Chrome for Windows, selecting developer tools and emulating a phone layout, I get the following error:

vc64_ui.js:3838 Uncaught ReferenceError: stationaryBase is not defined
at register_v_joystick (vc64_ui.js:3838:29)

The emulator just shows "Exception thrown, see JavaScript console".

I tried defining stationaryBase, but that leads to a new error:

virtualjoystick.js:30 Uncaught ReferenceError: current_vjoy_touch is not defined
at new VirtualJoystick (virtualjoystick.js:30:14)

Thank you for the great work.

@mithrendal
Copy link
Collaborator

mithrendal commented Dec 14, 2023

touch control in general is working when invoking the stand alone version at https://vc64web.github.io

confirmed:
when embedding vc64web in another web page with enabled virtual touch joystick then it crashes 🙈 ... investigating now

@mithrendal mithrendal added the bug Something isn't working label Dec 14, 2023
mithrendal added a commit that referenced this issue Dec 14, 2023
@mithrendal
Copy link
Collaborator

I think it is fixed now 🤓

@JesperJuul thanks for reporting

mithrendal added a commit that referenced this issue Dec 14, 2023
@JesperJuul
Copy link
Author

Amazing, thank you @mithrendal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants