Skip to content
This repository has been archived by the owner on Dec 14, 2020. It is now read-only.

Block on message disposition when rcv-settle-mode is second #74

Closed
vcabbage opened this issue Apr 11, 2018 · 0 comments · Fixed by #99
Closed

Block on message disposition when rcv-settle-mode is second #74

vcabbage opened this issue Apr 11, 2018 · 0 comments · Fixed by #99
Labels

Comments

@vcabbage
Copy link
Owner

amqp/client.go

Lines 1382 to 1389 in ee6eb7e

// TODO:
// When rcv-settle-mode == second, don't consider the transfer complete
// until caller accepts/reject/etc and a confirm from sender.
//
// At first glance, this appears to be at odds with batching. A batch can't
// be built up if the caller is blocked on confirmation. However, while receives
// must happen synchronously, confirmations do not. While the use is probably
// limited it may be worth exploring.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant