Skip to content
This repository has been archived by the owner on Dec 14, 2020. It is now read-only.

Wait for response disposition when Receiver w/ rcv-settle-mode second. #99

Merged
merged 1 commit into from Jun 18, 2018

Conversation

vcabbage
Copy link
Owner

@vcabbage vcabbage commented May 21, 2018

Also fixed some potential bugs due to receiver and sender dispositions being treated the same in Session.mux.

This adds error returns to Message.Accept/Reject/Release/Modify and is therefor a breaking change. Errors are not returned when batching is enabled and receiver settle mode is first.

Resolves #74

@vcabbage
Copy link
Owner Author

vcabbage commented Jun 4, 2018

Flow control w/ the buffered channel (link.transfers) needs to be fixed before this is finished. Tried a couple different ways but haven't come up with a non-hacky solution.

cc837c7 Was one of those attempts, but it doesn't really fix the problem, just makes it less likely to occur.

@vcabbage
Copy link
Owner Author

Fixed the flow control issues in #103.

Fixed some potential bugs due to receiver and sender dispostions
being treated them same in Session.mux.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block on message disposition when rcv-settle-mode is second
1 participant