Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for notification lights getting stuck #21

Closed
RedKrieg opened this issue May 20, 2021 · 3 comments
Closed

Fix for notification lights getting stuck #21

RedKrieg opened this issue May 20, 2021 · 3 comments

Comments

@RedKrieg
Copy link

I sometimes have an issue where many notifications in quick succession will cause the extension to "forget" to unset the notification color on the light. I was reviewing the Hue API and I believe adding "alert": "select" to the parameters you pass to setLights will let you skip the entire "restore lights to previous state" event. You may need to play with transitiontime instead of using the current value of 0 to make it look good though.

@vchlum
Copy link
Owner

vchlum commented May 23, 2021

Hi @RedKrieg, "alert": "select" is supposed to run notification, but it doesn't work well along with setting a specific color. Not changing the color, It works as expected - it uses the last know color. Changing the color has an unexpected and inconsistent behavior:-(

I am considering to add a timestamp to the restore state and in case the timestamp is fresh, the restore state would not be overwritten because many notifications are in progress...

@cm-t
Copy link

cm-t commented May 23, 2021

That's funny to see this issue right now, I, yesterday, exprienced this.

  • I opened thunderbird (or telegram, maybe both)
  • I had some notifications
  • light starter to play the notification color
  • I didn't focus on it a lot because it was at that moment I left the room, when I came back later (20min?) the light was still running the notification light instead of the scene it was displaying before.

@vchlum
Copy link
Owner

vchlum commented Jul 5, 2021

Issue fixed. Notifications have been redesigned to use queues. The problem shouldn't be possible to happen again.

@vchlum vchlum closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants