Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All / most of water objects should use "blockVisit" mode #42

Closed
krs0 opened this issue Aug 4, 2023 · 4 comments · Fixed by #78
Closed

All / most of water objects should use "blockVisit" mode #42

krs0 opened this issue Aug 4, 2023 · 4 comments · Fixed by #78

Comments

@krs0
Copy link
Contributor

krs0 commented Aug 4, 2023

@IvanSavenko can you please detail a little what this is about?

@IvanSavenko
Copy link
Contributor

In H3 most of buildings on land are visited when hero stands on top of them. E.g. hero needs to physically enter town/mine/dwelling to interact with it.

However, buildings on water are usually visited from tile next to the entrance - e.g. when you visit Mermaids your boat is not on top of Mermaids, but next to them.

In vcmi this is controlled by "blockVisit" / "blockedVisitable" property. If set to true, object will be visited when hero stands next to visited objects. And currently large number of new water objects from hota don't use such property.

@DjWarmonger
Copy link
Collaborator

Please wait for a proper solution of vcmi/vcmi#847

@misiokles
Copy link
Collaborator

This Issue can be closed?

@DjWarmonger DjWarmonger linked a pull request Dec 21, 2023 that will close this issue
@DjWarmonger
Copy link
Collaborator

Right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants