Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton Corpse blocks path #847

Closed
kambala-decapitator opened this issue Sep 6, 2022 · 10 comments · Fixed by #3259
Closed

Skeleton Corpse blocks path #847

kambala-decapitator opened this issue Sep 6, 2022 · 10 comments · Fixed by #3259
Assignees
Labels
bug rmg Random map generator

Comments

@kambala-decapitator
Copy link
Collaborator

kambala-decapitator commented Sep 6, 2022

You can't step onto the corpse hence you can't access Coliseum.

Screenshot 2022-09-06 at 15 26 03

Already saw such case twice on the same map and rather nearby.

@kambala-decapitator kambala-decapitator added bug rmg Random map generator labels Sep 6, 2022
@Nordsoft91
Copy link
Member

I though I fixed it...

@nullkiller
Copy link
Member

nullkiller commented Sep 7, 2022

Is it possible to bypass it by visiting? It is like resource BLOCKVIS object but which is not removed? I know one more such object -buoy. Btw there should be a way to understand if the object is removable. AI has a helper method for this I think but it should be a property of the object itself

@kambala-decapitator
Copy link
Collaborator Author

Is it possible to bypass it by visiting?

no:

You can't step onto the corpse

@misiokles
Copy link
Contributor

misiokles commented Sep 7, 2022

Maybe one-tile-square around such objects will do its job?

@Nordsoft91
Copy link
Member

@kambala-decapitator , for rmg issues, please attach client logs or at least map description, containing random seed and parameters used to generate map

@kambala-decapitator
Copy link
Collaborator Author

sorry, didn't save log of the map generation. Parameters:

Screenshot 2022-09-09 at 12 31 17

@kambala-decapitator
Copy link
Collaborator Author

another example (and Coliseum again):

Screenshot 2023-01-10 at 15 11 51
Screenshot 2023-01-10 at 16 09 39

@kambala-decapitator
Copy link
Collaborator Author

one more on the same map:

Screenshot 2023-01-15 at 12 29 44

@DjWarmonger DjWarmonger added this to the Release 1.3 milestone Mar 21, 2023
@DjWarmonger
Copy link
Member

DjWarmonger commented Mar 25, 2023

In order to properly handle that, we should be able to determine whether the object is removed after visit. If it is, there's no problem.
There is no such property in CGObjectInstance or ObjectTemplate.

Also, blockVisit is configured only after object is fully created (CRandomRewardObjectInfo::configureObject inside CGameState::initMapObjects()), so this info is not available during object placement.

@DjWarmonger
Copy link
Member

DjWarmonger commented Dec 6, 2023

Good news: Looks like right now, the issue only occurs when there are at least 2 corpses in a treasure pile.

Untitled Untitled (1) Untitled (2) Untitled (3) Untitled (4)

@DjWarmonger DjWarmonger removed this from the Release 1.3.2 milestone Dec 6, 2023
@DjWarmonger DjWarmonger linked a pull request Dec 6, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rmg Random map generator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants