Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8 compatibility #11

Merged
merged 3 commits into from
Jan 22, 2021
Merged

PHP8 compatibility #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71de446
Made pipette PHP8 compatible
gerritdrost Dec 18, 2020
aa178d4
Reverted unnecessary change to composer.json
gerritdrost Jan 22, 2021
1fd8682
Removed phpspec from deps. Added more phpspec documentation in README…
gerritdrost Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,4 +285,15 @@ Pipette's behaviour for any other type is undefined.

## Tests

Powered by [phpspec](http://www.phpspec.net/en/stable/): `php vendor/bin/phpspec run`
Powered by [phpspec](http://www.phpspec.net/en/stable/). phpspec is configured to gather code coverage information. This requires [xdebug](https://pecl.php.net/package/xdebug) or [pcov](https://pecl.php.net/package/pcov). You can also disable code coverage.

```
# default (using pcov)
php vendor/bin/phpspec run

# xdebug coverage
XDEBUG_MODE=coverage php vendor/bin/phpspec run

# no code coverage
php vendor/bin/phpspec run -c phpspec-nocc.yml
```
10 changes: 4 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
],

"require": {
"php": "^7.1",
"php": "^7.4|^8.0",
"ext-json": "*"
},

Expand All @@ -27,11 +27,9 @@
},

"require-dev": {
"ext-pcov": "*",

"friends-of-phpspec/phpspec-code-coverage": "^4.2.3",
"phpspec/phpspec": "^6.1.0",
"phpunit/phpunit": "^7.1",
"friends-of-phpspec/phpspec-code-coverage": "^6.0",
"phpspec/phpspec": "^7.0",
"phpunit/phpunit": "^9.5",
"justinrainbow/json-schema": "^5.2",
"vcn/enum": "^1.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on https://github.com/vcn/enum/pull/5/files

},
Expand Down
1 change: 0 additions & 1 deletion src/Json.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ public static function parse(string $source, int $depth = 512, int $options = 0)
*/
public static function pretend($value): Value
{
/** @noinspection PhpInternalEntityUsedInspection */
return new Value($value, '$');
}

Expand Down