Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove multi_json dependency, yajl-ruby use only JSON #815

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Remove multi_json dependency, yajl-ruby use only JSON #815

merged 1 commit into from
Apr 13, 2020

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Apr 11, 2020 •
edited
Loading

This is a WIP PR to explore does "stop using multi_json" as described in #789.

Fixes #789

Steps

  • remove the dependency
  • find errors in breaking tests
  • also, remove the now-unused yajl-ruby from the Gemfile

@olleolleolle olleolleolle marked this pull request as draft April 11, 2020 08:56
@olleolleolle olleolleolle force-pushed the avoid-multi_json branch 3 times, most recently from 6cfff2f to aa17642 Compare April 12, 2020 10:05
@olleolleolle olleolleolle changed the title Remove require of multi_json Remove multi_json dependency, use only JSON Apr 12, 2020
@olleolleolle olleolleolle force-pushed the avoid-multi_json branch 4 times, most recently from 820b7d7 to 999d2bf Compare April 12, 2020 11:22
@olleolleolle olleolleolle marked this pull request as ready for review April 12, 2020 11:27
@olleolleolle olleolleolle requested a review from a team April 12, 2020 11:27
@olleolleolle
Copy link
Member Author

(Can the dependency yajl-ruby also be dropped, with this?)

@olleolleolle olleolleolle changed the title Remove multi_json dependency, use only JSON Remove multi_json dependency, yajl-ruby use only JSON Apr 12, 2020
@olleolleolle
Copy link
Member Author

I think this is ready to go in.

@krainboltgreene krainboltgreene merged commit a9b6541 into master Apr 13, 2020
@krainboltgreene krainboltgreene deleted the avoid-multi_json branch April 13, 2020 01:04
This was referenced Nov 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krainboltgreene krainboltgreene krainboltgreene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VCR doesn't declare its dependency on multi_json
2 participants
@olleolleolle @krainboltgreene