Breaking: Require ruby 2.3 or newer, to be able to use latest Cucumber, for 2.7 support #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- by using new syntax for tag exclusion, we avoid all start warnings
|
Cc @mvz |
|
Update: Learning that the "features/test_frameworks/cucumber_feature" does not currently find more than 0 tests. Investigating. Learned: 2.4.0 won't work, so ditching that special-case "lower-version of Cucumber" test would make us go green (while still running tests). I kept a "Gemfile-cucumber-3.1", which is the current gemspec's choice, to see if we are able to support 4.0 and 3.1 when 4.0 drops. |
olleolleolle
force-pushed
the
require-ruby-23-and-up
branch
from
0ce65bf
to
ef2fe32
Compare
krainboltgreene
approved these changes
Apr 12, 2020
|
Can you mention explicit about support ruby 2.7? |
|
@choosen I'd merge a small PR if you have one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the required_ruby_version to
>= 2.3, in order to be able to run Cucumber tests.exconlibrary - Fixes Allow Excon >= 0.62.0 #814>= 2.3