Transforms ERB hash keys to symbol, in case string #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing an ERB hash with string keys was causing a NameError in struct cache initialization, as Struct members must be symbols. The NameError was being rescued and re-raised, saying the cassette "references undefined variable", which was misleading.
krainboltgreene
suggested changes
Sep 25, 2020
lib/vcr/cassette/erb_renderer.rb
Outdated
Comment on lines
43
to
45
| attributes.map!(&:to_sym) | ||
| hash[attributes] = Struct.new(*attributes) | ||
| end |
There was a problem hiding this comment.
Suggested change
| attributes.map!(&:to_sym) | |
| hash[attributes] = Struct.new(*attributes) | |
| end | |
| hash[attributes] = Struct.new(*attributes.map(&:to_sym)) | |
| end |
z1lk
commented
Sep 26, 2020
Comment on lines
+43
to
+45
| attributes = attributes.map(&:to_sym) | ||
| hash[attributes] = Struct.new(*attributes) unless hash.key?(attributes) | ||
| hash[attributes] |
There was a problem hiding this comment.
@krainboltgreene Your suggested change got me thinking about reducing the number of keys in the cache. All of the following end up creating Structs with the same members and should reuse the cached Struct rather than create a new one:
@@struct_cache[ [:a, :b] ]
@@struct_cache[ [:a, 'b'] ]
@@struct_cache[ ['a', :b] ]
@@struct_cache[ ['a', 'b'] ]
krainboltgreene
approved these changes
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing an ERB hash with string keys was causing a NameError in
struct cache initialization, as Struct members must be symbols.
The NameError was being rescued and re-raised, saying the cassette
"references undefined variable", which was misleading.