add VCR.turned_on #835
Merged
add VCR.turned_on #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
previously approved these changes
Oct 2, 2020
There was a problem hiding this comment.
This looks like a fairly complete addition, rounding out the API with an inverse of an existing method.
@krainboltgreene Do you like it, too?
olleolleolle
approved these changes
Oct 2, 2020
krainboltgreene
approved these changes
Oct 2, 2020
|
@hirowatari Could you add a CHANGELOG.md line about this? (Add it in a Unreleased section, at the top of the document, so that when we make a release, it's easy to turn that into a semver release section.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #834 this provides the method
VCR.turned_onsimilar toVCR.turned_off