Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a Host trailing dot to match same Host without it #838

Merged
merged 2 commits into from
Oct 4, 2020
Merged

Allow a Host trailing dot to match same Host without it #838

merged 2 commits into from
Oct 4, 2020

Conversation

hirowatari
Copy link
Contributor

Fixes #681. See for further comments.

@olleolleolle olleolleolle changed the title Host trailing dot Allow a Host trailing dot to match same Host without it Oct 4, 2020
olleolleolle
olleolleolle approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these equivalent!

Makes sense, and the implementation is straightforward and small.

@olleolleolle olleolleolle merged commit 7ea7e1d into vcr:master Oct 4, 2020
@olleolleolle
Copy link
Member

Ah, @hirowatari, this is super.

Can you add a line to the Changelog about this?

@hirowatari
Copy link
Contributor Author

Thanks @olleolleolle. Updated the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VCR doesn't match URLs ending with a single dot (.)
2 participants
@hirowatari @olleolleolle