Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add ruby 3.0 build matrix, and remove 2.4 #900

Merged
merged 11 commits into from
Sep 1, 2021
Merged

Conversation

aka47
Copy link
Contributor

@aka47 aka47 commented Aug 30, 2021

Ruby 3.0 got released some time ago, lets make sure it works in all cases with vcr

Ruby 3.0 got released some time ago, lets make sure it works in all cases with vcr
@aka47 aka47 marked this pull request as ready for review August 30, 2021 09:34
ruby 3.0 does not bundle webrick by default
comment_blueprint.rb Outdated Show resolved Hide resolved
@aka47
Copy link
Contributor Author

aka47 commented Aug 30, 2021

@olleolleolle any ideas on those 2 failing cucumber specs. I am missing a hint right now how this connects.

They are..

  • bundle exec cucumber features/http_libraries/net_http.feature:143
  • features/test_frameworks/test_unit.feature:6

@olleolleolle
Copy link
Member

@olleolleolle any ideas on those 2 failing cucumber specs. I am missing a hint right now how this connects.

They are..

* bundle exec cucumber features/http_libraries/net_http.feature:143

* features/test_frameworks/test_unit.feature:6

Do they fail in isolation, locally?

@aka47
Copy link
Contributor Author

aka47 commented Aug 30, 2021

@olleolleolle any ideas on those 2 failing cucumber specs. I am missing a hint right now how this connects.
They are..

* bundle exec cucumber features/http_libraries/net_http.feature:143

* features/test_frameworks/test_unit.feature:6

Do they fail in isolation, locally?

Yes - they also fail locally on my mac. Not for ruby 2.7 - but with ruby 3..

@olleolleolle
Copy link
Member

@aka47 Then it looks a bit like the Webrick server never starts correctly

- upgrade cucumber and test-unit to its latest version
- fix 2 failing specs
upgrading cucumber needs also an upgrade of typhoeus from 0.4 to 1.4. Should be done - but not all in one.
@aka47
Copy link
Contributor Author

aka47 commented Aug 31, 2021

How about removing ruby 2.4 support for new releases? Nobody should use it anyways.. this is the warning I get when I install it..

WARNING: ruby-2.4.10 is past its end of life and is now unsupported.
It no longer receives bug fixes or critical security updates.

@olleolleolle
Copy link
Member

olleolleolle commented Aug 31, 2021

Removing 2.4 support would be good. #903

ruby 2.4 is long outdated and not maintained anymore. To concentrate resources, the support is dropped at this point.
@olleolleolle olleolleolle changed the title add ruby 3.0 to ruby matrix in github actions CI: Add ruby 3.0 build matrix, and remove 2.4 Sep 1, 2021
README.md Outdated Show resolved Hide resolved
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We have gotten to green. I retitled, and added a small README change for precision.

Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@aka47
Copy link
Contributor Author

aka47 commented Sep 1, 2021

Great. Lets squash and merge it then... :)

I would suggest to upgrade cucumber to 7.0 and remove the outdated typhoeus 0.4.0 patch and testing - ( it is from June 08, 2012) ) - does that make sense?

@olleolleolle
Copy link
Member

@aka47 I agree with both efforts as separate Issues we would like to address!

@olleolleolle olleolleolle merged commit 98a7e01 into vcr:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants