-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add ruby 3.0 build matrix, and remove 2.4 #900
Conversation
Ruby 3.0 got released some time ago, lets make sure it works in all cases with vcr
ruby 3.0 does not bundle webrick by default
@olleolleolle any ideas on those 2 failing cucumber specs. I am missing a hint right now how this connects. They are..
|
Do they fail in isolation, locally? |
Yes - they also fail locally on my mac. Not for ruby 2.7 - but with ruby 3.. |
@aka47 Then it looks a bit like the Webrick server never starts correctly |
- upgrade cucumber and test-unit to its latest version - fix 2 failing specs
upgrading cucumber needs also an upgrade of typhoeus from 0.4 to 1.4. Should be done - but not all in one.
How about removing ruby 2.4 support for new releases? Nobody should use it anyways.. this is the warning I get when I install it..
|
Removing 2.4 support would be good. #903 |
ruby 2.4 is long outdated and not maintained anymore. To concentrate resources, the support is dropped at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We have gotten to green. I retitled, and added a small README change for precision.
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
Great. Lets squash and merge it then... :) I would suggest to upgrade cucumber to 7.0 and remove the outdated typhoeus 0.4.0 patch and testing - ( it is from June 08, 2012) ) - does that make sense? |
@aka47 I agree with both efforts as separate Issues we would like to address! |
Ruby 3.0 got released some time ago, lets make sure it works in all cases with vcr