Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for typhoeus 0.4 #905

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

aka47
Copy link
Contributor

@aka47 aka47 commented Sep 1, 2021

tyhoeus 0.4 was release almost 10 years ago and is long outdated. The current version is 1.4
Lets remove all patches and specs that target this version.

tyhoeus 0.4 was release almost 10 years ago and is long outdated. Lets remove all patches and specs that target this version.
spec/monkey_patches.rb Outdated Show resolved Hide resolved
@aka47 aka47 marked this pull request as ready for review September 1, 2021 13:32
@aka47
Copy link
Contributor Author

aka47 commented Sep 1, 2021

I believe it looks good and can be merged..

@olleolleolle olleolleolle changed the title drop support for tyhoeus 0.4 Drop support for typhoeus 0.4 Sep 1, 2021
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This drops patches and special support for an ancient version of Typheous.

@olleolleolle olleolleolle merged commit 2b46c02 into vcr:master Sep 1, 2021
@olleolleolle
Copy link
Member

@aka47 Thanks for maintaining this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants