Dont attempt to parse a invalid response(nil) when using hook_into :excon
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
previously approved these changes
Jan 1, 2022
andrehjr
force-pushed
the
fix-excon-middleware-errors-before-body
branch
from
9cba6f7
to
88b77db
Compare
andrehjr
force-pushed
the
fix-excon-middleware-errors-before-body
branch
from
88b77db
to
f7a8a69
Compare
|
Done @olleolleolle ! Thanks for the review 馃檶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃檶
When using
hook_into :exconand dealing with an internal error from Excon(i.e: OpenSSL::SSL::SSLError)VCR::Middleware::Excon::Response#error_callwas breaking because it was trying to parse/record a nil response. The error happened here on Logger#response_summary, becauseresponseis nil.I think that the correct behavior would be to let Excon throw its own error up the stack as there's nothing recorded yet here and there's no need for VCR to attempt to read an empty response for this scenario. Please, correct me if I'm wrong.
When using
hook_into :webmockthe error is thrown and no cassette is recorded. Same things happens here now.Fixes #651