Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs: Renaming #417

Merged
merged 6 commits into from Sep 23, 2022
Merged

URLs: Renaming #417

merged 6 commits into from Sep 23, 2022

Conversation

tony
Copy link
Member

@tony tony commented Sep 21, 2022

  • refactor(url):
    • Matcher -> Rule, MatcherRegistry -> Rules
    • matches -> rule_map
    • default_patterns -> patterns
    • MATCHERS -> RULES

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #417 (a038571) into master (5834604) will not change coverage.
The diff coverage is 87.71%.

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   61.16%   61.16%           
=======================================
  Files          35       35           
  Lines        2758     2758           
  Branches      662      662           
=======================================
  Hits         1687     1687           
  Misses        642      642           
  Partials      429      429           
Impacted Files Coverage Δ
src/libvcs/url/base.py 83.33% <72.72%> (ø)
src/libvcs/url/hg.py 93.87% <81.81%> (ø)
src/libvcs/url/svn.py 89.79% <81.81%> (ø)
src/libvcs/url/git.py 98.73% <100.00%> (ø)
tests/url/test_git.py 100.00% <100.00%> (ø)
tests/url/test_hg.py 100.00% <100.00%> (ø)
tests/url/test_svn.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony
Copy link
Member Author

tony commented Sep 21, 2022

This is just renaming

I had this open at 6AM / while waking up and never merged it, but do this after work:

URLs: Rename match to rule (#417)

  • Matcher -> Rule, MatcherRegistry -> Rules
  • matches -> rule_map
  • default_patterns -> patterns
  • MATCHERS -> RULES

@tony tony merged commit 853ccb7 into master Sep 23, 2022
@tony tony deleted the simplify-urls-try-two branch September 23, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant