Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd(Git.rev_list): Fix variable expansion #455

Merged
merged 2 commits into from Feb 17, 2024
Merged

cmd(Git.rev_list): Fix variable expansion #455

merged 2 commits into from Feb 17, 2024

Conversation

tony
Copy link
Member

@tony tony commented Feb 17, 2024

Fixes vcs-python/vcspull#438

Changes

Fix Git.rev_list()

Was not handling flags like max_count correctly.

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e34d4b2) 62.67% compared to head (8ca612e) 62.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   62.67%   62.67%           
=======================================
  Files          39       39           
  Lines        3445     3445           
  Branches      927      927           
=======================================
  Hits         2159     2159           
  Misses        770      770           
  Partials      516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony merged commit 58924a5 into master Feb 17, 2024
7 checks passed
@tony tony deleted the fix-rev-list branch February 17, 2024 11:21
tony added a commit to vcs-python/vcspull that referenced this pull request Feb 17, 2024
tony added a commit to vcs-python/vcspull that referenced this pull request Feb 17, 2024
tony added a commit to vcs-python/vcspull that referenced this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal: '--max-count': not an integer
1 participant