Linting: Aggressive ruff pass (ruff v0.3.4) #442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format .
Fixed 39 errors:
2 × PT003 (pytest-extraneous-scope-function)
1 × PIE790 (unnecessary-placeholder)
1 × RET505 (superfluous-else-return)
4 × RET505 (superfluous-else-return)
1 × PLR6201 (literal-membership)
src/vcspull/cli/__init__.py
:2 × TID252 (relative-imports)
1 × I001 (unsorted-imports)
1 × RET505 (superfluous-else-return)
4 × TID252 (relative-imports)
1 × PLR5501 (collapsible-else-if)
1 × E303 (too-many-blank-lines)
1 × RSE102 (unnecessary-paren-on-raise-exception)
1 × RET504 (unnecessary-assign)
1 × ISC001 (single-line-implicit-string-concatenation)
2 × E303 (too-many-blank-lines)
2 × RET504 (unnecessary-assign)
1 × FLY002 (static-join-to-f-string)
1 × PLR1733 (unnecessary-dict-index-lookup)
2 × PIE804 (unnecessary-dict-kwargs)
1 × PT001 (pytest-fixture-incorrect-parentheses-style)
2 × PT003 (pytest-extraneous-scope-function)