fix for user edit bug => Issue #58

[Xelaflash]

What this Pull Request do ?

Fixing the edit user bug (issue #58)
Fix:
• Some mandatory Devise config for strong params where missing in app/controllers/application_controllers.rb
• In app/views/devise/registrations/edit.html.erb: the default fields (password, password_confirmation and current_password) were not present in the form preventing the save action for User#edit to pass.
(note: current password is mandatory for Devise#edit action)

Close an issue ? please insert the hash

Close #58

Required migrations ?

[] yes [x] no

Add a new gem ?

[] yes [x] no

Add a new package ?

[] yes [x] no

[vczb]

@Xelaflash Hello, thank you for your pull request. We are using prettier to format the files, can you run yarn prettier:format and submit the PR again please ? this is necessary to approve on CI

[vczb]

Very nice, just a I18n key missing, waiting to the fix.

[vczb]

Can you please add this text to I18n ?

https://github.com/vczb/gamou/tree/main/config/locales

create a new key on config/locales/en/en.yml and add this text like this

I18n.t('my.new.key')

its necessary replicate add this content on pt-BR locale too config/locales/pt-BR/pt-BR.yml with te content

"Precisamos de sua senha atual para confirmar suas alterações"

If you need help im available

[vczb]

@Xelaflash i don't understand why need the password three times.

What you think about the password confirmation is the last information on the form ? just one time only, use the * CURRENT PASSWORD

[Xelaflash]

Hi,
i'll handle the prettier and the i48n (sorry did pay attention to internationalisation part).

For the password fields, they are part of Devise default views and also default strong params.
We could always remove them as they are not required but as for UX i believe that as a user i should be able to modify my password in my account page.
But this is totally up to you and we can remove those 2 fields and put the current_password (which is mandatory) at the end of the form.

Just confirm what you decide.

[vczb]

Hi, i'll handle the prettier and the i48n (sorry did pay attention to internationalisation part).

For the password fields, they are part of Devise default views and also default strong params. We could always remove them as they are not required but as for UX i believe that as a user i should be able to modify my password in my account page. But this is totally up to you and we can remove those 2 fields and put the current_password (which is mandatory) at the end of the form.

Just confirm what you decide.

ok, good answer, we can keep the 3 password fields, but lets move to the last input of the form ?

[vczb]

Hi, i'll handle the prettier and the i48n (sorry did pay attention to internationalisation part).

For the password fields, they are part of Devise default views and also default strong params. We could always remove them as they are not required but as for UX i believe that as a user i should be able to modify my password in my account page. But this is totally up to you and we can remove those 2 fields and put the current_password (which is mandatory) at the end of the form.

Just confirm what you decide.

Or just move the * CURRENT PASSWORD to the down of * DIAMOND PRICE IN CENTS, will be good!

---

PR preview:

https://gamou-pr-79.herokuapp.com/

[Xelaflash]

Changes have been made.

1. run prettier
2. change positioning of current_password field
3. edit en locale for new text (translation where actually un pt-BR file, cause they are devise default, therefore i did not touch the translation, please check if ok on your side)
4. change a little bit the styling of the devise help text (smaller and lighter)

[vczb]

Changes have been made.

1. run prettier
2. change positioning of current_password field
3. edit en locale for new text (translation where actually un pt-BR file, cause they are devise default, therefore i did not touch the translation, please check if ok on your side)
4. change a little bit the styling of the devise help text (smaller and lighter)

You are the best, thank you!