Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Alert component #18

Closed
vczb opened this issue Oct 1, 2022 · 10 comments
Closed

Create Alert component #18

vczb opened this issue Oct 1, 2022 · 10 comments

Comments

@vczb
Copy link
Owner

vczb commented Oct 1, 2022

  • check the other components to undertand the pattern and style-guide
  • should be reusable

Alert example:

https://mui.com/material-ui/react-alert/

@yamitrvg12
Copy link

Hey vczb, can you assign me this task so that I can work on it?

@vczb
Copy link
Owner Author

vczb commented Oct 1, 2022

Hey vczb, can you assign me this task so that I can work on it?

Assigned! thank you 🚀

@yamitrvg12
Copy link

working on it...

@yamitrvg12
Copy link

Hey vczb I have completed this task #38. Could you please take a look it and if everything is OK could you please merge and add the "hacktoberfest-accepted" tag to it.
Thank you!

@vczb
Copy link
Owner Author

vczb commented Oct 4, 2022

Hey vczb I have completed this task #38. Could you please take a look it and if everything is OK could you please merge and add the "hacktoberfest-accepted" tag to it. Thank you!

Ok, I will review it ASAP. don't worry about the CI, I will fix the build error later

@yamitrvg12
Copy link

vczb I saw that you merged :), could you please add "hacktoberfest-accepted" tag to it.

@vczb
Copy link
Owner Author

vczb commented Oct 4, 2022

Hey vczb I have completed this task #38. Could you please take a look it and if everything is OK could you please merge and add the "hacktoberfest-accepted" tag to it. Thank you!

Ok, I will review it ASAP. don't worry about the CI, I will fix the build error later

Is already added

image

@vczb
Copy link
Owner Author

vczb commented Oct 4, 2022

Closed by #38

@vczb vczb closed this as completed Oct 4, 2022
@vczb
Copy link
Owner Author

vczb commented Oct 4, 2022

vczb I saw that you merged :), could you please add "hacktoberfest-accepted" tag to it.

Hi @yamitrvg12 check the hacktoberfest page in feel minutes. Your merge already have the accepted tag. Any question let me know

@yamitrvg12
Copy link

awesome, thank you vczb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants