-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Alert component #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like your job. I left some comments to improve the PR, when you will add the request changes use rebase or amend to avoid creating a secondary commit.
don't worry about the CI.
src/packages/Alert/styles.ts
Outdated
background: transparent; | ||
border: none; | ||
cursor: pointer; | ||
font-size: 12px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font-size: ${theme.font.sizes.xsmall} // is equal to 12px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
font-size: 12px; | ||
line-height: 1; | ||
outline: none !important; | ||
padding-top: ${theme.spacings.mini}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why important is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
src/styles/theme/colors.ts
Outdated
@@ -1,6 +1,7 @@ | |||
export const base = { | |||
alert: '#DC2626', | |||
success: '#22C55E', | |||
warning: '#fff4e5', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will use this warning or the alert.warning ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
src/styles/theme/colors.ts
Outdated
@@ -30,9 +31,17 @@ export const neutral = { | |||
xdarkest: '#4D4D4D' | |||
} | |||
|
|||
export const alerts = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let replace to status
will be more generalist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.