Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Theme Customization section on the README #84

Closed
vczb opened this issue Jun 23, 2023 · 2 comments
Closed

Improve Theme Customization section on the README #84

vczb opened this issue Jun 23, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers react

Comments

@vczb
Copy link
Owner

vczb commented Jun 23, 2023

We should improve the Theme Customization section on here:

image

should improve this exemple as:

....
  Object.assign(theme.colors.primary, { medium: "#510763" });

  return (
    <SaguProvider theme={theme}>
....

and here:

image

  const customColors = {
    tertiary: {
      lighter: "#fb973a",
      light: "#e37c1d",
      medium: "#da710f",
      dark: "#9e4c01"
    }
  };

  Object.assign(theme.colors, customColors);
  
  return (
    <SaguProvider theme={theme}>

please, be smart... you need to keep the rest of the example and add the improvement, make sure that it is properly formatted etc... thanks

@vczb vczb added documentation Improvements or additions to documentation good first issue Good for newcomers react labels Jun 23, 2023
@KikiQianSun
Copy link
Contributor

Hi, could you assign this issue to me, please?

@vczb
Copy link
Owner Author

vczb commented Oct 26, 2023

closed by #121

@vczb vczb closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers react
Projects
None yet
Development

No branches or pull requests

2 participants