Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed and made required changes to README file #79

Closed
wants to merge 2 commits into from
Closed

fixed and made required changes to README file #79

wants to merge 2 commits into from

Conversation

siddarthpai
Copy link
Contributor

Please review

@vczb
Copy link
Owner

vczb commented Jun 9, 2023

hello @siddarthpai, thanks for contributing but something is wrong here. You have changed 60 files
image

please rebase with master and add a single commit with updates the README file

Copy link
Owner

@vczb vczb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reading your PR and the code is completely outside of our patterns, please check the components that we current have and understand how they are builded.

optinally you can create your component using the command yarn generate <component-name> in your case yarn generate Stepper. Using the generated boilerplate you can move foward on it.


additional note: do not install new dependencies, use styled-components as css-in-js approach.

when you have all your changes done, run the linters and tests. you can verify how to execute it on the README file or checking the scripts on the package.json

then squash your changes in a single commit and update the PR

thanks in advance, any question fell free to ask

@siddarthpai
Copy link
Contributor Author

will redo it and send you a pr .
apology for the issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants