feat: Minor improvements to code style #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vd2org
requested changes
Apr 2, 2024
| @@ -56,7 +64,7 @@ def seconds(self) -> float: | |||
| def datetime(self) -> datetime: | |||
| return datetime.utcfromtimestamp(self.seconds) | |||
|
|
|||
| def datetime_tz(self, tz: Optional[tzinfo] = None) -> datetime: | |||
| def datetime_tz(self, tz: Optional[tzinfo] = None) -> 'datetime': | |||
There was a problem hiding this comment.
Raises type errors in newer Python versions.
There was a problem hiding this comment.
Checked on 3.11 and 3.12. No errors there. Did I miss something?
There was a problem hiding this comment.
It was raising unknown type errors when using pyright for 3.12.2
There was a problem hiding this comment.
Can't reproduce it. Could you share the full example, please?
|
Updated for <3.10 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya, I made some improvements to the typing along with updating the module to follow PEP best practices such as using
__all__in the__init__file & not shadowing variable types onSnowflakeGenerator.__init__. Additionally, I've updated both classes to use__slots__which improves overal performance.