Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grpc reflection #1064

Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Mar 7, 2021

Signed-off-by: kpango kpango@vdaas.org

Description:

support grpc reflection protocols for Vald
https://github.com/grpc/grpc/blob/master/doc/server-reflection.md

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.16
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Mar 7, 2021

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Mar 7, 2021

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #1064 (eb5fa3a) into master (972f77d) will increase coverage by 0.57%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
+ Coverage   14.42%   15.00%   +0.57%     
==========================================
  Files         495      498       +3     
  Lines       28408    28770     +362     
==========================================
+ Hits         4098     4317     +219     
- Misses      24054    24178     +124     
- Partials      256      275      +19     
Impacted Files Coverage Δ
internal/config/server.go 0.00% <0.00%> (ø)
internal/servers/server/option.go 92.19% <100.00%> (+0.07%) ⬆️
internal/servers/server/server.go 69.65% <100.00%> (ø)
internal/db/storage/blob/s3/reader/reader.go 63.04% <0.00%> (-31.53%) ⬇️
internal/errgroup/group.go 92.42% <0.00%> (-1.52%) ⬇️
internal/worker/worker.go 83.33% <0.00%> (ø)
internal/net/option.go 89.65% <0.00%> (ø)
internal/net/dialer.go 79.42% <0.00%> (ø)
internal/net/net.go 45.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee24f6f...a94a522. Read the comment docs.

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the feature/grpc/add-grpc-reflection-for-more-useful-connectivity branch from 0206c31 to 3b3c2ca Compare March 7, 2021 14:34
@github-actions github-actions bot added size/XXL and removed size/L labels Mar 7, 2021
@kpango kpango merged commit 30f3fe5 into master Mar 8, 2021
@kpango kpango deleted the feature/grpc/add-grpc-reflection-for-more-useful-connectivity branch March 8, 2021 04:54
@vdaas-ci vdaas-ci mentioned this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants