Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go module #1643

Merged
merged 1 commit into from
May 13, 2022
Merged

update go module #1643

merged 1 commit into from
May 13, 2022

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Apr 28, 2022

Signed-off-by: kpango kpango@vdaas.org

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.3

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango force-pushed the dependency/go-module/update-go-deps branch 3 times, most recently from 9067999 to 55cc1a3 Compare May 12, 2022 07:32
vankichi
vankichi previously approved these changes May 12, 2022
hlts2
hlts2 previously approved these changes May 12, 2022
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the dependency/go-module/update-go-deps branch from 1766582 to 990bf04 Compare May 12, 2022 07:41
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the size/M label May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1643 (990bf04) into master (c10358f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1643   +/-   ##
=======================================
  Coverage   30.71%   30.72%           
=======================================
  Files         372      372           
  Lines       32234    32234           
=======================================
+ Hits         9900     9903    +3     
+ Misses      21965    21964    -1     
+ Partials      369      367    -2     
Impacted Files Coverage Δ
...nt/core/ngt/service/vqueue/uninserted_index_map.go 73.22% <0.00%> (-5.47%) ⬇️
internal/worker/worker.go 83.59% <0.00%> (ø)
pkg/agent/core/ngt/service/option.go 91.41% <0.00%> (+1.84%) ⬆️
...ent/core/ngt/service/vqueue/undeleted_index_map.go 73.88% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10358f...990bf04. Read the comment docs.

@kpango kpango merged commit 13c62b1 into master May 13, 2022
@kpango kpango deleted the dependency/go-module/update-go-deps branch May 13, 2022 00:09
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants