Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add troubleshooting flow chart document #1688

Merged
merged 12 commits into from
Jun 14, 2022

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jun 3, 2022

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I have added the flow chart for troubleshooting and a new document file for it.

I wonder whether divide troubleshooting documents into chart.md and troubleshooting.md and this chart covers almost trouble for the Vald cluster.
Please feedback.

I have created the new document directory, troubleshooting.
The document tres is here:
|- 📁 troubleshooting
| |- 📝 README : overview of this directory (the path will be /docs/troubleshooting/ on the web site)
| |- 📝 Flow Chart : showing troubleshooting flow chart for the Vald cluster
| |- 📝 Operation Troubleshooting : introducing troubleshooting for client operation

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 3, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi force-pushed the documentation/docs/add-troble-shooting-chart branch 3 times, most recently from 4269a2a to d2a7861 Compare June 6, 2022 01:36
@vankichi vankichi changed the title [WIP] add troubleshooting flow chart document add troubleshooting flow chart document Jun 6, 2022
@vankichi vankichi requested review from kmrmt and kevindiu June 6, 2022 01:37
@vankichi vankichi marked this pull request as ready for review June 6, 2022 01:39
Copy link
Contributor

@kmrmt kmrmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About troubleshooting_chart.svg, in my environment that is google chrome version 102.0.5005.61, Linux(Voyager Linux 22..04 LTS, kernel 5.15.0-33-generic) and google chrome version 102.0.5005.63 and Windows 11, the whole of command is not visible like below.

In Linux

$ kubectl get pod -o w

In Windows

$ kubectl get pod

@vankichi vankichi force-pushed the documentation/docs/add-troble-shooting-chart branch from d2a7861 to b3b6db6 Compare June 6, 2022 04:53
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the documentation/docs/add-troble-shooting-chart branch from 7da54c5 to 7ebe170 Compare June 6, 2022 07:45
@kmrmt kmrmt self-requested a review June 6, 2022 08:25
kmrmt
kmrmt previously approved these changes Jun 6, 2022
@kevindiu
Copy link
Contributor

kevindiu commented Jun 6, 2022

I am sorry that I want to confirm what content do you expect on chat.md and trobleshooting.md?

@kevindiu
Copy link
Contributor

kevindiu commented Jun 6, 2022

I think it may be better to use End instead of black circle point as I can't understand what it means.
Also do we need @taisuou to review the design after/during we review the content of the diagram?

@vankichi
Copy link
Contributor Author

vankichi commented Jun 7, 2022

I am sorry that I want to confirm what content do you expect on chat.md and trobleshooting.md?

I meant should we combine chart.md and troubleshooting.mg in one file or keep 2 files.
Please give me your thoughts.

@vankichi
Copy link
Contributor Author

vankichi commented Jun 7, 2022

I think it may be better to use End instead of black circle point as I can't understand what it means. Also do we need @taisuou to review the design after/during we review the content of the diagram?

The black circle means the end of the flow chart, and I think it is the general expression.
Nevertheless, do you think it should be changed?

IMO, it is not needed.
Anyway, we have to pass the review from all core contributors.

@kevindiu
Copy link
Contributor

kevindiu commented Jun 7, 2022

The black circle means the end of the flow chart, and I think it is the general expression.

This is the first time I see this expression, however I couldn't find any example that represent the end of the flow chart as a black circle, do you have any reference for it?
I could only find the circle with the End wording is the similar expression from yours.

Ref: https://duckduckgo.com/?q=flowchart+end&atb=v314-1&iax=images&ia=images&iai=https%3A%2F%2Fcdn2.slidemodel.com%2Fwp-content%2Fuploads%2F6658-01-business-process-infographics-16x9-1.jpg

@kevindiu
Copy link
Contributor

kevindiu commented Jun 7, 2022

I meant should we combine chart.md and troubleshooting.mg in one file or keep 2 files.
Please give me your thoughts.

I think we can combine them as I think splitting them cause harder to find the flow chart, what do you think?

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the documentation/docs/add-troble-shooting-chart branch from b8544ff to 59a2a60 Compare June 7, 2022 03:45
@kevindiu
Copy link
Contributor

kevindiu commented Jun 7, 2022

Sorry again but I found 2 more typo on runnig.

  • Filter Gateway runnig
  • Filter Component is runnig

kmrmt
kmrmt previously approved these changes Jun 7, 2022
Signed-off-by: vankichi <kyukawa315@gmail.com>
kevindiu
kevindiu previously approved these changes Jun 8, 2022
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi requested a review from kmrmt June 8, 2022 07:16
kmrmt
kmrmt previously approved these changes Jun 8, 2022
hlts2
hlts2 previously approved these changes Jun 13, 2022
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should describe about helm-operator upgrading.
user have to update thier CRDs.
it would be better to embed command or add links to the upgrade document

@vankichi
Copy link
Contributor Author

vankichi commented Jun 13, 2022

@kpango

I think we should describe about helm-operator upgrading. user have to update thier CRDs. it would be better to embed command or add links to the upgrade document

Yes, I thinks so.
I have embedded the upgrade document link at the upgrate vald-helm-operator.
I suppose Github PR preview page does not apply. You can verify on the page of the original file path.

Here -> https://raw.githubusercontent.com/vdaas/vald/documentation/docs/add-troble-shooting-chart/assets/docs/troubleshooting/troubleshooting_chart.svg

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi dismissed stale reviews from hlts2, kmrmt, and kevindiu via c422da9 June 13, 2022 08:51
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vankichi vankichi merged commit 4d97509 into master Jun 14, 2022
@vankichi vankichi deleted the documentation/docs/add-troble-shooting-chart branch June 14, 2022 05:57
@kevindiu kevindiu mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants