Add cluster role document #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Deploying with
|
| Latest commit: |
2da065f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6b0bc7e0.vald.pages.dev |
| Branch Preview URL: | https://documentation-update-cluster.vald.pages.dev |
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
kevindiu
force-pushed
the
documentation/update-cluster-role-binding-doc
branch
from
7e0af67
to
290aea1
Compare
kevindiu
requested review from
vankichi,
a team and
hlts2
and removed request for
a team
Signed-off-by: kevindiu <kevindiujp@gmail.com>
vankichi
requested changes
Oct 12, 2022
|
|
||
| In Vald, the index is distributed across the cluster depending on the resource usage of the cluster, it requires settings to grant permission to a specific role to retrieve cluster information on Kubernetes. | ||
|
|
||
| In Vald, the settings are deployed automatically when using helm to deploy. |
There was a problem hiding this comment.
🤔 ?
It seems not logical sentence considering the below links.
could you please re-think sentence?
There was a problem hiding this comment.
added this sentence to connect the content.
|
|
||
| All of these rules are required to retrieve Nodes and Pods resource usage from [kube-apiserver](https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/) and also used to discover new Vald Agents or Nodes created on the cluster. | ||
|
|
||
| ### Cluster role binding settings |
There was a problem hiding this comment.
What would you like to describe?
For cluster role binding only discoverer, or overall?
It should be formatted the section title and sentences.
There was a problem hiding this comment.
fixed by changing the title
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
vankichi
requested changes
Oct 17, 2022
|
|
||
| These configurations allow the service account `discoverer` to access different resources in the Kubernetes cluster. | ||
|
|
||
| ### Cluster role settings for Vald Discoverer |
There was a problem hiding this comment.
It is little bit logical scheme, why this page shows only discoverer.
It should be mentioned why we describe only discoverer.
User may not understand the flow of the story.
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
kevindiu
commented
Oct 18, 2022
vankichi
previously approved these changes
Oct 18, 2022
Signed-off-by: kevindiu <kevindiujp@gmail.com>
kevindiu
commented
Oct 18, 2022
kevindiu
commented
Oct 18, 2022
vankichi
approved these changes
Oct 18, 2022
kpango
approved these changes
Oct 18, 2022
kpango
pushed a commit
that referenced
this pull request
Oct 18, 2022
* add cluster role document Signed-off-by: kevindiu <kevindiujp@gmail.com> * update flowchat and add cluster role setting for cloud providers Signed-off-by: kevindiu <kevindiujp@gmail.com> * fix grammar Signed-off-by: kevindiu <kevindiujp@gmail.com> * update flowchart Signed-off-by: kevindiu <kevindiujp@gmail.com> * fix comment Signed-off-by: kevindiu <kevindiujp@gmail.com> * fix comment Signed-off-by: kevindiu <kevindiujp@gmail.com> * Update docs/user-guides/cluster-role-binding.md * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * fix comment Signed-off-by: kevindiu <kevindiujp@gmail.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * fix image Signed-off-by: kevindiu <kevindiujp@gmail.com> * Update docs/user-guides/cluster-role-binding.md * Update docs/user-guides/cluster-role-binding.md * Update cluster-role-binding.md * fix comment Signed-off-by: kevindiu <kevindiujp@gmail.com> * Update docs/user-guides/cluster-role-binding.md * Update docs/user-guides/cluster-role-binding.md * Update cluster-role-binding.md Signed-off-by: kevindiu <kevindiujp@gmail.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Signed-off-by: kpango <kpango@vdaas.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kevindiu kevindiujp@gmail.com
Description:
This PR include the following changes:
assets/docs/troubleshooting/troubleshooting.drawiotoassets/docs/troubleshooting/provisioning_flow_chart.drawioRelated Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: