Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document format #1804

Merged
merged 2 commits into from Oct 15, 2022
Merged

Fix document format #1804

merged 2 commits into from Oct 15, 2022

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Oct 6, 2022

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.19.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi marked this pull request as ready for review October 6, 2022 08:15
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Oct 6, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 15, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5dec14c
Status: ✅  Deploy successful!
Preview URL: https://33892c61.vald.pages.dev
Branch Preview URL: https://documentation-update-documen.vald.pages.dev

View logs

@kpango kpango merged commit 3cd360e into main Oct 15, 2022
@kpango kpango deleted the documentation/update-document-format branch October 15, 2022 05:18
@kpango kpango mentioned this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants