Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest to deploy opentelemetry-operator #1819

Merged
merged 11 commits into from Oct 26, 2022

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Oct 24, 2022

Description:

WHAT

I added makefile command and manifest for opentelemetry-operator and collector and prometheus-operator

WHY

we need to support OTLP for monitoring

FYI

The following is an example structure for monitoring platform.

                                        ===> Jaeger
                                       ||
Vald ===> OpenTelemetry Collector  ====
                                       ||
                                        ===> Prometheus <=== Grafana

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 changed the title Add manifest to deploy otel-operator Add manifest to deploy opentelemetry-operator Oct 24, 2022
@hlts2 hlts2 self-assigned this Oct 24, 2022
@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 24, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 681dd9f
Status: ✅  Deploy successful!
Preview URL: https://7e8ec9ed.vald.pages.dev
Branch Preview URL: https://feature-k8s-add-otel-collect.vald.pages.dev

View logs

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@github-actions github-actions bot added size/L and removed size/M labels Oct 24, 2022
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 force-pushed the feature/k8s/add-otel-collector branch from 51379e3 to 1b1bbb8 Compare October 24, 2022 09:40
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested review from kpango and datelier October 25, 2022 01:21
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@github-actions github-actions bot added size/M and removed size/M labels Oct 25, 2022
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@github-actions github-actions bot added size/M and removed size/M labels Oct 25, 2022
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2
Copy link
Contributor Author

hlts2 commented Oct 26, 2022

@kpango @datelier
Thank you for your review!
I will merge this PR!

@hlts2 hlts2 merged commit 97c4d15 into main Oct 26, 2022
@hlts2 hlts2 deleted the feature/k8s/add-otel-collector branch October 26, 2022 05:59
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants