Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install make dependencies before format command #1828

Merged
merged 1 commit into from
Nov 2, 2022
Merged

install make dependencies before format command #1828

merged 1 commit into from
Nov 2, 2022

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Nov 2, 2022 •
edited
Loading

Signed-off-by: kpango kpango@vdaas.org

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

I love beer 🍻

@kpango
fix makefile
34bfa1a 
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango requested review from hlts2 and vankichi November 2, 2022 05:51
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Nov 2, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi
Copy link
Contributor

vankichi commented Nov 2, 2022

thanks

hlts2
hlts2 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 5f2ce25 into main Nov 2, 2022
@kpango kpango deleted the refactor/makefile/install-deps-on-format branch November 2, 2022 07:58
kpango added a commit that referenced this pull request Nov 11, 2022
@kpango
fix makefile (#1828)
3468ef0 
Signed-off-by: kpango <kpango@vdaas.org>

Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Nov 11, 2022
@kpango
fix makefile (#1828)
c5f3355 
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Nov 14, 2022
@kpango
fix makefile (#1828)
e7f8084 
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Nov 15, 2022
@kpango
fix makefile (#1828)
1d44a37 
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Nov 16, 2022
@kpango
fix makefile (#1828)
c7c4b5e 
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Nov 17, 2022
@kpango
fix makefile (#1828)
9a79dad 
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Nov 18, 2022
@kpango
fix makefile (#1828)
856acd0 
fix

Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Nov 18, 2022
@kpango
fix makefile (#1828) fix
31763ca 
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Nov 18, 2022
@kpango
fix makefile (#1828) fix
5b6b8b7 
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Nov 18, 2022
@kpango
fix makefile (#1828) fix
f3aa612 
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vankichi vankichi vankichi approved these changes

@hlts2 hlts2 hlts2 approved these changes

Assignees
No one assigned
Labels
area/makefile priority/low size/S team/sre SRE team type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kpango @vdaas-ci @vankichi @hlts2