Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deepsource: [RVV-B0009] Redefinition of builtin #1858

Merged
merged 2 commits into from Nov 22, 2022

Conversation

datelier
Copy link
Contributor

@datelier datelier commented Nov 22, 2022

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 30.54% // Head: 30.53% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e7947f4) compared to base (d7345dc).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1858      +/-   ##
==========================================
- Coverage   30.54%   30.53%   -0.02%     
==========================================
  Files         367      367              
  Lines       33823    33828       +5     
==========================================
- Hits        10331    10329       -2     
- Misses      23079    23084       +5     
- Partials      413      415       +2     
Impacted Files Coverage Δ
hack/helm/schema/crd/main.go 0.00% <0.00%> (ø)
hack/helm/schema/gen/main.go 0.00% <0.00%> (ø)
internal/cache/cache.go 100.00% <100.00%> (ø)
internal/cache/cacher/cacher.go 100.00% <100.00%> (ø)
...ent/core/ngt/service/vqueue/undeleted_index_map.go 68.30% <0.00%> (-3.28%) ⬇️
internal/net/http/middleware/timeout.go 93.33% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Nov 22, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e7947f4
Status: ✅  Deploy successful!
Preview URL: https://5916c6e9.vald.pages.dev
Branch Preview URL: https://refactoring-rvv-b0009-redefi.vald.pages.dev

View logs

@vankichi vankichi merged commit 9a2f9fd into main Nov 22, 2022
@vankichi vankichi deleted the refactoring/RVV-B0009/redefinition-of-builtin branch November 22, 2022 02:34
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants