Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: VET-V0008 Lock erroneously passed by value internal/db, backoff, circuitbreaker #1859

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Nov 22, 2022

Description:

As titled.

the following are refactor targets.

  • internal/backoff
  • internal/circuitbreaker
  • internal/db

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 changed the title Fix deepsource: VET-V0008 Lock erroneously passed by value Fix deepsource: VET-V0008 Lock erroneously passed by value internal/db, backoff, circuitbreaker Nov 22, 2022
@hlts2 hlts2 self-assigned this Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 30.53% // Head: 30.54% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e0a67e6) compared to base (9a2f9fd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1859      +/-   ##
==========================================
+ Coverage   30.53%   30.54%   +0.01%     
==========================================
  Files         367      367              
  Lines       33828    33828              
==========================================
+ Hits        10328    10333       +5     
+ Misses      23085    23082       -3     
+ Partials      415      413       -2     
Impacted Files Coverage Δ
internal/worker/queue.go 98.73% <0.00%> (-1.27%) ⬇️
internal/worker/worker.go 82.30% <0.00%> (-0.77%) ⬇️
internal/net/http/middleware/timeout.go 93.33% <0.00%> (+2.22%) ⬆️
...ent/core/ngt/service/vqueue/undeleted_index_map.go 71.58% <0.00%> (+3.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Nov 22, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e0a67e6
Status: ✅  Deploy successful!
Preview URL: https://451dee0d.vald.pages.dev
Branch Preview URL: https://refactor-vet-v008-lock-error.vald.pages.dev

View logs

@vankichi vankichi merged commit dc4c84c into main Nov 22, 2022
@vankichi vankichi deleted the refactor/VET-V008/lock-error branch November 22, 2022 02:53
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants