Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: VET-V0008 Lock erroneously passed by value (pkg/manager) #1861

Merged

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Nov 22, 2022

Description:

SSIA.
Deepsource warning fixed:

  • pkg/manager/index/service/indexer_test.go
  • pkg/manager/index/service/indexinfos_test.go

This PR also regenerate test code of pkg/manager package.
All files are regenerated.

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Signed-off-by: kevindiu <kevindiujp@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kevindiu kevindiu force-pushed the refactor/VET-V0008/lock-erroneously-passed-by-value-pkg-manager branch from 8d185f0 to 08454ea Compare November 22, 2022 02:30
@cloudflare-pages
Copy link

cloudflare-pages bot commented Nov 22, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 39e3d70
Status: ✅  Deploy successful!
Preview URL: https://77cff1ca.vald.pages.dev
Branch Preview URL: https://refactor-vet-v0008-lock-erro-s4sw.vald.pages.dev

View logs

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 50.23% // Head: 30.53% // Decreases project coverage by -19.69% ⚠️

Coverage data is based on head (39e3d70) compared to base (97eed29).
Patch coverage: 34.01% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1861       +/-   ##
===========================================
- Coverage   50.23%   30.53%   -19.70%     
===========================================
  Files         231      367      +136     
  Lines       13464    33828    +20364     
===========================================
+ Hits         6764    10331     +3567     
- Misses       6499    23083    +16584     
- Partials      201      414      +213     
Impacted Files Coverage Δ
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
hack/benchmark/assets/x1b/loader.go 0.00% <ø> (ø)
hack/benchmark/internal/assets/dataset.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/insert.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/operation.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/option.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/remove.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/search.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/util.go 0.00% <ø> (ø)
...ck/benchmark/internal/starter/gateway/vald/vald.go 0.00% <0.00%> (ø)
... and 273 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kevindiu kevindiu changed the title [WIP] Fix deepsource: VET-V0008 Lock erroneously passed by value (pkg/manager) Fix deepsource: VET-V0008 Lock erroneously passed by value (pkg/manager) Nov 22, 2022
@kevindiu kevindiu marked this pull request as ready for review November 22, 2022 02:43
pkg/manager/index/service/indexer_test.go Outdated Show resolved Hide resolved
pkg/manager/index/service/indexer_test.go Outdated Show resolved Hide resolved
pkg/manager/index/service/indexer_test.go Outdated Show resolved Hide resolved
Signed-off-by: kevindiu <kevindiujp@gmail.com>
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit 000b913 into main Nov 22, 2022
@vankichi vankichi deleted the refactor/VET-V0008/lock-erroneously-passed-by-value-pkg-manager branch November 22, 2022 10:15
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants