Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: VET-V0008 Lock erroneously passed by value internal/client #1862

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Nov 22, 2022

Description:

As titled

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 self-assigned this Nov 22, 2022
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 30.54% // Head: 30.54% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (0bdf574) compared to base (d7345dc).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1862   +/-   ##
=======================================
  Coverage   30.54%   30.54%           
=======================================
  Files         367      367           
  Lines       33823    33828    +5     
=======================================
+ Hits        10331    10334    +3     
- Misses      23079    23081    +2     
  Partials      413      413           
Impacted Files Coverage Δ
hack/helm/schema/crd/main.go 0.00% <0.00%> (ø)
hack/helm/schema/gen/main.go 0.00% <0.00%> (ø)
internal/cache/cache.go 100.00% <100.00%> (ø)
internal/cache/cacher/cacher.go 100.00% <100.00%> (ø)
internal/info/info.go 88.35% <100.00%> (ø)
internal/worker/worker.go 82.30% <0.00%> (-0.77%) ⬇️
internal/net/http/middleware/timeout.go 93.33% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Nov 22, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0bdf574
Status: ✅  Deploy successful!
Preview URL: https://2ef12393.vald.pages.dev
Branch Preview URL: https://refactor-vet-v008-client-loc.vald.pages.dev

View logs

@vankichi vankichi merged commit 288e665 into main Nov 22, 2022
@vankichi vankichi deleted the refactor/VET-V008/client-lock-error branch November 22, 2022 04:10
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants