Fix deepsource: VET-V0008 Lock erroneously passed by value (internal/test, singleflight, observability) #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
github-actions
bot
added
area/internal
team/set
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov ReportBase: 30.54% // Head: 30.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
==========================================
- Coverage 30.54% 30.53% -0.02%
==========================================
Files 367 367
Lines 33828 33828
==========================================
- Hits 10333 10328 -5
- Misses 23081 23086 +5
Partials 414 414
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kevindiu
previously approved these changes
Nov 22, 2022
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying with
|
| Latest commit: |
8acb023
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14ea5d7b.vald.pages.dev |
| Branch Preview URL: | https://refactor-vet-v0008-lock-erro-u4le.vald.pages.dev |
vankichi
approved these changes
Nov 22, 2022
kevindiu
approved these changes
Nov 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As titled
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: