Fix deepsource: VET-V0008 Lock erroneously passed by value (pkg/agent)

[kevindiu]

Description:

SSIA.

For the test implementation fix of vqueue/queue_test.go, I have applied the fix to the test case implementation like below.

type uiimNoLock struct {
	read   atomic.Value
	dirty  map[string]*entryUiim
	misses int
}

...
type fields struct {
		uii  []index
        // define internal structure of uiim without mu
		uiim uiimNoLock
....
	tests := []test{
		func() test {
			var uiim uiim
			for _, idx := range uii {
				uiim.Store(idx.uuid, idx)
			}

			return test{
				name: "return (nil, false) when the uiid dose not exist in uiim",
				fields: fields{
        // copy the uiim internal values created from the test case
					uiim: uiimNoLock{
						read:   uiim.read,
						dirty:  uiim.dirty,
						misses: uiim.misses,
					},
				},
....

	for _, tc := range tests {
		test := tc
		t.Run(test.name, func(tt *testing.T) {
....
			v := &vqueue{
				uii: test.fields.uii,
         // copy the value to uiim
				uiim: uiim{
					read:   test.fields.uiim.read,
					dirty:  test.fields.uiim.dirty,
					misses: test.fields.uiim.misses,
				},

Related Issue:

Versions:

• Go Version: 1.19.2
• Docker Version: 20.10.8
• Kubernetes Version: 1.22.0
• NGT Version: 1.14.8

Checklist:

• I have read the CONTRIBUTING document and completed our CLA agreement.
• I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - replace the PR body by changelog details
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase main
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[codecov]

Codecov Report

Base: 30.52% // Head: 30.56% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (ed2d1d6) compared to base (3153939).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1868      +/-   ##
==========================================
+ Coverage   30.52%   30.56%   +0.04%     
==========================================
  Files         367      367              
  Lines       33829    33829              
==========================================
+ Hits        10325    10340      +15     
+ Misses      23088    23076      -12     
+ Partials      416      413       -3     

Impacted Files	Coverage Δ
internal/net/dialer.go	77.40% <0.00%> (-1.00%)	⬇️
internal/worker/worker.go	83.84% <0.00%> (+1.53%)	⬆️
...nt/core/ngt/service/vqueue/uninserted_index_map.go	79.03% <0.00%> (+8.60%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[cloudflare-pages]

Deploying with    Cloudflare Pages

Latest commit:	ed2d1d6
Status:	✅  Deploy successful!
Preview URL:	https://00749ef2.vald.pages.dev
Branch Preview URL:	https://refactor-vet-v0008-lock-erro-9r5q.vald.pages.dev

View logs